Comments on: Torturing Ruby (and laughing at your own code) http://www.railsguru.com/articles/2007/08/21/torturing-ruby-and-laughing-at-your-own-code/ Andy Lo-A-Foe's weblog Mon, 15 Feb 2010 16:03:41 +0000 http://wordpress.org/?v=2.9.1 hourly 1 By: p3t0r http://www.railsguru.com/articles/2007/08/21/torturing-ruby-and-laughing-at-your-own-code/comment-page-1/#comment-290 p3t0r Tue, 21 Aug 2007 22:50:00 +0000 http://www.railsguru.com/2007/08/21/torturing-ruby-and-laughing-at-your-own-code#comment-290 What about: number.to_s.scan(/\d{1,4}/) What about:

number.to_s.scan(/\d{1,4}/)

]]> By: p3tor http://www.railsguru.com/articles/2007/08/21/torturing-ruby-and-laughing-at-your-own-code/comment-page-1/#comment-291 p3tor Tue, 21 Aug 2007 22:50:00 +0000 http://www.railsguru.com/2007/08/21/torturing-ruby-and-laughing-at-your-own-code#comment-291 I just had to pass my solution to flog: <pre> Total score = 2.89233901885654 main#splice_number: (2.9) 1.3: to_s 1.1: scan 1.1: assignment 0.3: lit_fixnum </pre> I just had to pass my solution to flog:
<pre>
Total score = 2.89233901885654

main#splice_number: (2.9)
1.3: to_s
1.1: scan
1.1: assignment
0.3: lit_fixnum
</pre>

]]> By: p3t0r http://www.railsguru.com/articles/2007/08/21/torturing-ruby-and-laughing-at-your-own-code/comment-page-1/#comment-292 p3t0r Tue, 21 Aug 2007 22:50:00 +0000 http://www.railsguru.com/2007/08/21/torturing-ruby-and-laughing-at-your-own-code#comment-292 I simplified a bit to much, didn't put the 'part_size' into the equation, this should do the same as yours: <pre> def splice_number(number, part_size = 4) p = Regexp.new("\\d{1,#{part_size}}") number.to_s.scan(p) end </pre> And results in a 4.4 <pre> Total score = 4.36928197762516 main#splice_number: (4.4) 2.2: assignment 1.3: to_s 1.1: new 1.1: scan 0.3: lit_fixnum </pre> I simplified a bit to much, didn’t put the ‘part_size’ into the equation, this should do the same as yours:

<pre>
def splice_number(number, part_size = 4)
p = Regexp.new("\\d{1,#{part_size}}")
number.to_s.scan(p)
end
</pre>

And results in a 4.4

<pre>
Total score = 4.36928197762516

main#splice_number: (4.4)
2.2: assignment
1.3: to_s
1.1: new
1.1: scan
0.3: lit_fixnum
</pre>

]]> By: andy http://www.railsguru.com/articles/2007/08/21/torturing-ruby-and-laughing-at-your-own-code/comment-page-1/#comment-293 andy Tue, 21 Aug 2007 22:50:00 +0000 http://www.railsguru.com/2007/08/21/torturing-ruby-and-laughing-at-your-own-code#comment-293 Excellent!! :-) Excellent!! :-)

]]> By: andy http://www.railsguru.com/articles/2007/08/21/torturing-ruby-and-laughing-at-your-own-code/comment-page-1/#comment-294 andy Tue, 21 Aug 2007 22:50:00 +0000 http://www.railsguru.com/2007/08/21/torturing-ruby-and-laughing-at-your-own-code#comment-294 I completely miss the presence of the scan method call, and in Ruby fashion is supports regex! -andy I completely miss the presence of the scan method call, and in Ruby fashion is supports regex!

-andy

]]> By: p3t0r http://www.railsguru.com/articles/2007/08/21/torturing-ruby-and-laughing-at-your-own-code/comment-page-1/#comment-295 p3t0r Tue, 21 Aug 2007 22:50:00 +0000 http://www.railsguru.com/2007/08/21/torturing-ruby-and-laughing-at-your-own-code#comment-295 You miss the presence of the scan call? The above really works in ruby, I've tested it! You miss the presence of the scan call? The above really works in ruby, I’ve tested it!

]]> By: andy http://www.railsguru.com/articles/2007/08/21/torturing-ruby-and-laughing-at-your-own-code/comment-page-1/#comment-296 andy Tue, 21 Aug 2007 22:50:00 +0000 http://www.railsguru.com/2007/08/21/torturing-ruby-and-laughing-at-your-own-code#comment-296 What I meant, *I* didn't know about the scan call in the Ruby String class :-) .. very handy indeed, thanks!!<br/> <br/> -andy What I meant, *I* didn’t know about the scan call in the Ruby String class :-) .. very handy indeed, thanks!!<br/>
<br/>
-andy

]]> By: Eric Hodel http://www.railsguru.com/articles/2007/08/21/torturing-ruby-and-laughing-at-your-own-code/comment-page-1/#comment-297 Eric Hodel Tue, 21 Aug 2007 22:50:00 +0000 http://www.railsguru.com/2007/08/21/torturing-ruby-and-laughing-at-your-own-code#comment-297 <pre>$ flog def splice_number(number, part_size = 4) number.to_s.scan(/\d{1,#{part_size}}/) end Total score = 3.775 none#splice_number: (3.8) 1.3: to_s 1.1: scan 1.1: assignment 0.3: lit_fixnum</pre> <pre>$ flog
def splice_number(number, part_size = 4)
number.to_s.scan(/\d{1,#{part_size}}/)
end
Total score = 3.775

none#splice_number: (3.8)
1.3: to_s
1.1: scan
1.1: assignment
0.3: lit_fixnum</pre>

]]> By: Ryan Davis http://www.railsguru.com/articles/2007/08/21/torturing-ruby-and-laughing-at-your-own-code/comment-page-1/#comment-298 Ryan Davis Tue, 21 Aug 2007 22:50:00 +0000 http://www.railsguru.com/2007/08/21/torturing-ruby-and-laughing-at-your-own-code#comment-298 Great article... unpack is indeed the way to go.<br/> That a* + delete is more expensive than just seeing if it is needed in the first place:<br/> <br/> <pre> def splice_number6(n, p = 4) # flog = 10.92, time = 5.17 n = n.to_s s = n.size c = s / p fmt = "a#{p}" * c fmt << "a*" unless s == p * c n.unpack(fmt) end </pre> Here are the flog (1.1) scores + times for the above implementations: <pre> flog = 32.26, time = 10.48 flog = 10.51, time = 06.54 flog = 10.36, time = 06.70 flog = 04.37, time = 12.32 # peter flog = 02.89, time = 11.82 # eric flog = 10.92, time = 05.17 # me </pre> Great article… unpack is indeed the way to go.<br/>
That a* + delete is more expensive than just seeing if it is needed in the first place:<br/>
<br/>
<pre>
def splice_number6(n, p = 4)
# flog = 10.92, time = 5.17
n = n.to_s
s = n.size
c = s / p
fmt = "a#{p}" * c
fmt &lt;&lt; "a*" unless s == p * c
n.unpack(fmt)
end
</pre>

Here are the flog (1.1) scores + times for the above implementations:

<pre>
flog = 32.26, time = 10.48
flog = 10.51, time = 06.54
flog = 10.36, time = 06.70
flog = 04.37, time = 12.32 # peter
flog = 02.89, time = 11.82 # eric
flog = 10.92, time = 05.17 # me
</pre>

]]> By: p3t0r http://www.railsguru.com/articles/2007/08/21/torturing-ruby-and-laughing-at-your-own-code/comment-page-1/#comment-299 p3t0r Tue, 21 Aug 2007 22:50:00 +0000 http://www.railsguru.com/2007/08/21/torturing-ruby-and-laughing-at-your-own-code#comment-299 @EricHodel Thanks, didn't know you could use th #{ notation inside a regexp like that! @RyanDavis Yeah, I'd expect regex to be outperformed by unpack. The regexp method is IMHO a bit more flexible.. one could easily make it have a 'min_part_size' or work on character strings. @EricHodel Thanks, didn’t know you could use th #{ notation inside a regexp like that!
@RyanDavis Yeah, I’d expect regex to be outperformed by unpack. The regexp method is IMHO a bit more flexible.. one could easily make it have a ‘min_part_size’ or work on character strings.

]]>