Comments on: Using MPlayer identify with Ruby http://www.railsguru.com/articles/2006/07/12/using-mplayer-identify-with-ruby/ Andy Lo-A-Foe's blog Thu, 01 Sep 2011 02:55:44 +0000 hourly 1 http://wordpress.org/?v=3.3 By: p3t0r http://www.railsguru.com/articles/2006/07/12/using-mplayer-identify-with-ruby/comment-page-1/#comment-39 p3t0r Wed, 12 Jul 2006 12:13:00 +0000 http://www.railsguru.com/2007/07/30/using-mplayer-identify-with-ruby#comment-39 Cool hack! I tried to figure out why you use the <em>compact!</em> function... doesn't this return nil if it didn't make any changes? <pre> irb(main):001:0> ["a","b","c"].compact! => nil irb(main):002:0> ["a","b","c",nil].compact! => ["a", "b", "c"] irb(main):003:0> ["a","b","c",nil].compact => ["a", "b", "c"] </pre> Using <em>compact</em> seems safer to me... Cool hack!

I tried to figure out why you use the <em>compact!</em> function… doesn’t this return nil if it didn’t make any changes?
<pre>

irb(main):001:0> ["a","b","c"].compact!
=> nil
irb(main):002:0> ["a","b","c",nil].compact!
=> ["a", "b", "c"]
irb(main):003:0> ["a","b","c",nil].compact
=> ["a", "b", "c"]

</pre>

Using <em>compact</em> seems safer to me…

]]> By: andy http://www.railsguru.com/articles/2006/07/12/using-mplayer-identify-with-ruby/comment-page-1/#comment-40 andy Wed, 12 Jul 2006 12:13:00 +0000 http://www.railsguru.com/2007/07/30/using-mplayer-identify-with-ruby#comment-40 According to the specs yes, but this is never an issue in this case. But you are right, it is still safer to use compact, nice catch :) -andy According to the specs yes, but this is never an issue in this case. But you are right, it is still safer to use compact, nice catch :)

-andy

]]> By: albert http://www.railsguru.com/articles/2006/07/12/using-mplayer-identify-with-ruby/comment-page-1/#comment-41 albert Wed, 12 Jul 2006 12:13:00 +0000 http://www.railsguru.com/2007/07/30/using-mplayer-identify-with-ruby#comment-41 I had to do something similar. Check out my version, based on yours. http://pastie.caboo.se/40788 I had to do something similar. Check out my version, based on yours.

http://pastie.caboo.se/40788

]]> By: andy http://www.railsguru.com/articles/2006/07/12/using-mplayer-identify-with-ruby/comment-page-1/#comment-42 andy Wed, 12 Jul 2006 12:13:00 +0000 http://www.railsguru.com/2007/07/30/using-mplayer-identify-with-ruby#comment-42 @albert: much more robust implementation, nice!<br/> <br/> thx,<br/> andy @albert: much more robust implementation, nice!<br/>
<br/>
thx,<br/>
andy

]]>